Skip to content

feat(status-bar): improve status bar display and actions #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skyrpex merged 4 commits into from
Sep 5, 2025
Merged

feat(status-bar): improve status bar display and actions #32

skyrpex merged 4 commits into from
Sep 5, 2025

Conversation

@skyrpex
Copy link
Collaborator

@skyrpex skyrpex commented Sep 5, 2025 •
edited
Loading

  • The status bar will always show the LS instance status (running, stopping, etc) if the LS CLI is installed — it doesn’t need to have the full setup complete
  • The status bar commands will always allow starting and stopping LS if the LS CLI is installed — it doesn’t need to have the full setup complete
  • The status bar setup wizard command will be displayed on top of the rest of the commands
  • The status bar will be red if any part of the setup is incomplete
  • The status bar text now uses a colon as a separator, instead of parentheses

@skyrpex
feat(status-bar): improve logic that shows "start", "stop" and "setup…
97c453b 
… wizard" commands
@skyrpex
wip
505f11a
@skyrpex
feat(status-bar): improve status bar display and actions
3b7a2b6 
- The status bar will always show the LS instance status (running, stopping, etc) if the LS CLI is installed — it doesn’t need to have the full setup complete
- The status bar commands will always allow starting and stopping LS if the LS CLI is installed — it doesn’t need to have the full setup complete
- The status bar will be red if any part of the setup is incomplete
tiurin
tiurin approved these changes Sep 5, 2025
View reviewed changes
Copy link
Collaborator

@tiurin tiurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement, thank you! Commands are much more relevant to each situation now. And the code is much more straightforward thanks to the introduction should... functions. 👏

@skyrpex skyrpex merged commit 6a0c0fd into main Sep 5, 2025
3 checks passed
@skyrpex skyrpex deleted the improve-status-bar branch September 5, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiurin tiurin tiurin approved these changes

@anisaoshafi anisaoshafi Awaiting requested review from anisaoshafi anisaoshafi is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skyrpex @tiurin